CI: Build for x86_64-unknown-linux-gnux32.
#464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephlr
added a commit
that referenced
this pull request
Jun 7, 2024
This PR merges the "extra" Linux tests into a single job. This reduces the number of jobs we have to run as part of the CI. We also explictly install libc and libgcc (to make it clear these are the only extra dev dependancies). I also added building/linking of the x32 target. As noted in #464, this will not run in the current github actions runner due to an incompatible kernel config. Signed-off-by: Joe Richey <[email protected]>
josephlr
added a commit
to josephlr/getrandom
that referenced
this pull request
Jun 7, 2024
This PR merges the "extra" Linux tests into a single job. This reduces the number of jobs we have to run as part of the CI. We also explictly install libc and libgcc (to make it clear these are the only extra dev dependancies). I also added building/linking of the x32 target. As noted in rust-random#464, this will not run in the current github actions runner due to an incompatible kernel config. Signed-off-by: Joe Richey <[email protected]>
|
I like this idea, but we should also link on this target, as it's only running which poses a problem. Closing as part of #466 (which also simplifies some of our Linux cross-compilation). |
josephlr
added a commit
that referenced
this pull request
Jun 7, 2024
This PR explictly installs libc and libgcc (to make it clear these are the only extra dev dependancies). I also added building/linking of the x32 target. As noted in #464, this will not run in the current github actions runner due to an incompatible kernel config. Signed-off-by: Joe Richey <[email protected]>
josephlr
added a commit
that referenced
this pull request
Jun 7, 2024
This PR explictly installs libc and libgcc (to make it clear these are the only extra dev dependancies). I also added building/linking of the x32 target. As noted in #464, this will not run in the current github actions runner due to an incompatible kernel config. Signed-off-by: Joe Richey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot run the tests on the Ubuntu runners but we can build for the target.