Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsound use of str::from_utf8_unchecked in ferris-says #1848

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Unsound use of str::from_utf8_unchecked in ferris-says #1848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions crates/ferris-says/RUSTSEC-0000-0000.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "ferris-says"
date = "2024-01-13"
url = "https://github.com/rust-lang/ferris-says/pull/21"
informational = "unsound"

[versions]
patched = [">= 0.3.1"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that a version 0.3.0 for this crate does not exist. The crate version went from 0.2.1 to 0.3.1 in rust-lang/ferris-says@570d876.

unaffected = ["<= 0.1.2"]
```

# Unsound use of str::from_utf8_unchecked on bytes which are not UTF-8

Affected versions receive a `&[u8]` from the caller through a safe API, and pass
it directly to the unsafe `str::from_utf8_unchecked` function.

The behavior of `ferris_says::say` is undefined if the bytes from the caller
don't happen to be valid UTF-8.

The flaw was corrected in [ferris-says#21] by using the safe `str::from_utf8`
instead, and returning an error on invalid input. However this fix has not yet
been published to crates.io as a patch version for 0.2.

Separately, [ferris-says#32] has introduced a different API for version 0.3
which accepts input as `&str` rather than `&[u8]`, so is unaffected by this bug.

[ferris-says#21]: https://github.com/rust-lang/ferris-says/pull/21
[ferris-says#32]: https://github.com/rust-lang/ferris-says/pull/32