fix(windows): fixup cgo errors #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`go build` won't download deps automatically, it need `go mod tidy`. Signed-off-by: Fu Lin <[email protected]>
When rust-std-x86_64-pc-windows-msvc is used, compiling go will reports error: error occurred: ToolExecError: failed to build Go library (exit code: 1). Build output: === stderr: # runtime/cgo cgo: C compiler "C:\\Program" not found: exec: "C:\\Program": file does not exist The reason is that golang uses MSVC (cl.exe) instead of gcc but golang don't support MSVC. At the same time, golang can't be built as static. Here use cfg to control compilier selection, and add doc. Signed-off-by: Fu Lin <[email protected]>
time-river
force-pushed
the
main
branch
2 times, most recently
from
a6fcd7d to
df88939
Compare
time-river
changed the title
Original `cfg!(windows)` don't work, and MinGW toolchain .a for static link, .dll for dynamic link. Otherwise it reports error: /usr/bin/x86_64-w64-mingw32-ld: cannot find -lxxx: No such file or directory Signed-off-by: Fu Lin <[email protected]>
Signed-off-by: Fu Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
I build it in windows platform very hardly. Maybe others problem still exists.
Signed-off-by: Fu Lin [email protected]