-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(LockCachingAudioSource): add network error handling #1398
base: minor
Are you sure you want to change the base?
feat(LockCachingAudioSource): add network error handling #1398
Conversation
59c9929
to
1a04045
Compare
@ryanheise I'm having troubles trying to test multiple scenarios, can you please give me a hint? I added a retry logic on the fetch method, but that's running without awaiting it. And for some reason, if an exception is thrown there or the future returns an error, it is not being propagated to the main await, where: |
Try to fix:
LockCachingAudioSource
does not recover from network errors #594Done: