Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 871, 'IcMetadata.Info can be stale' #884

Open
wants to merge 11 commits into
base: minor
Choose a base branch
from
Open

Fix bug 871, 'IcMetadata.Info can be stale' #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
201d200
Forked Ryan's JustAudio git project, updated pubspec.yaml, and added …
mrelac Nov 20, 2022
d96bf69
Create README.md
mrelac Nov 20, 2022
b815b9a
Added print statements to java and dart code and modified the example…
mrelac Nov 20, 2022
0653098
Merge branch 'minor' of https://github.com/mrelac/just_audio_icy into…
mrelac Nov 20, 2022
fb8f756
Updated README and debug print statements.
mrelac Nov 23, 2022
9338299
I found a solution. Since a valid header with a metadataInterval valu…
mrelac Nov 25, 2022
5bfca32
tweaked README and code to use const name rather than int value.
mrelac Nov 25, 2022
35afccd
Merge branch 'ryanheise:minor' into minor
mrelac Nov 26, 2022
fc1dd7f
Removed print statements and modifications that illustrate bug 871. T…
mrelac Nov 26, 2022
26d40b7
Updated CHANGELOG.md
mrelac Nov 26, 2022
d7eee06
Added comment to fix and removed exterraneous code in example_radio.d…
mrelac Nov 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions .idea/workspace.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions just_audio/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* Add a package parameter to AudioPlayer.setAsset() (@ewertonls).
* Add AudioSource.asset(), AudioSource.file().
* Fix tests for dart-sdk 2.5 (@ewertonls).
* Fix bug 871, stale icyMetadata shows previous stream's info and url.

## 0.9.30

Expand Down
4 changes: 4 additions & 0 deletions just_audio/android/src/main/java/com/ryanheise/just_audio/AudioPlayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,10 @@ public void onTracksChanged(Tracks tracks) {
final Metadata.Entry entry = metadata.get(k);
if (entry instanceof IcyHeaders) {
icyHeaders = (IcyHeaders) entry;
// null out info if interval is unset (bug 871)
if (icyHeaders.metadataInterval == C.LENGTH_UNSET) {
icyInfo = null;
}
broadcastImmediatePlaybackEvent();
}
}
Expand Down