Skip to content

Add broadcasting over containers, close #20#33

Open
jverzani wants to merge 3 commits into
s-celles:mainfrom
jverzani:broadcast
Open

Add broadcasting over containers, close #20#33
jverzani wants to merge 3 commits into
s-celles:mainfrom
jverzani:broadcast

Conversation

@jverzani
Copy link
Copy Markdown
Contributor

@jverzani jverzani commented May 19, 2026

Close issue #20

For GiacExpr

  • adds broadcastable trait (needed to reach into subtype). Returns object, Vector, or Matrix
  • Changed adjoint definition (also reached into subtype)
  • Modify size to reflect if VECT or matrix
  • Modify transpose to adjust for Giac vectors being row vectors (not column vectors)

For GiacMatrix

  • added axes method
  • added IteratorSize trait
  • added broadcastable
  • added adjoint
  • added method for map based on :apply

Added some tests

Still has an issue (broadcasting over a scalar variable) that I can't resolve (as far as I could tell the issue resolves to the underlying type not carrying enough detail about an object)

Note:

This changes the behavior of collect(M::GiacMatrix) to return a Matrix, not a vector, hence the broken test. (Which should be removed, but I wanted to flag the change.)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.31%. Comparing base (681f1ad) to head (40555a7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   79.76%   80.31%   +0.55%     
==========================================
  Files          23       23              
  Lines        2891     2921      +30     
==========================================
+ Hits         2306     2346      +40     
+ Misses        585      575      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jverzani jverzani changed the title WIP: add broadcasting over containers add broadcasting over containers, close #20 May 20, 2026
@jverzani jverzani changed the title add broadcasting over containers, close #20 WIP: add broadcasting over containers, close #20 May 20, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.38%. Comparing base (681f1ad) to head (237095c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   79.76%   80.38%   +0.62%     
==========================================
  Files          23       23              
  Lines        2891     2932      +41     
==========================================
+ Hits         2306     2357      +51     
+ Misses        585      575      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jverzani jverzani changed the title WIP: add broadcasting over containers, close #20 Add broadcasting over containers, close #20 May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants