Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed roles from input elements for cccessibility compliance #3442

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

Avaray
Copy link
Contributor

@Avaray Avaray commented Jan 31, 2025

Removed the role="tab" attribute from the input element due to a Google Lighthouse warning about using ARIA roles incorrectly. This role was unnecessary and could negatively affect accessibility scores. The removal is not expected to impact functionality.

Removed the role="tab" attribute from the input element due to a Google Lighthouse warning about using ARIA roles incorrectly. This role was unnecessary and could negatively affect accessibility scores. The removal is not expected to impact functionality.
@saadeghi saadeghi self-assigned this Feb 1, 2025
@saadeghi saadeghi merged commit 85e7d00 into saadeghi:v5 Feb 6, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants