-
Notifications
You must be signed in to change notification settings - Fork 1
Add new property types, catch invalid city names #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-new-property-types
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for multiple property types by refactoring all references from “flat” to “home” and adding a new CLI option for property types. Key changes include:
- Renaming and updating data model and test names from Flat to Home.
- Adding the new –property-type (–t) option to filter search queries.
- Updating documentation, changelog, and email messaging to reflect the new property terminology.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_email.py | Updated tests to use Home instead of Flat. |
| tests/test_data_models.py | Updated test cases and descriptions from Flat to Home. |
| tests/test_cache.py | Updated caching tests with Home references. |
| src/bolig_ping/scraper.py | Updated scraping functionality to work with Home objects. |
| src/bolig_ping/email.py | Updated email composition for Home listings. |
| src/bolig_ping/data_models.py | Refactored Flat to Home and added property_type handling. |
| src/bolig_ping/cli.py | Updated CLI options, including the new property type flag. |
| src/bolig_ping/cache.py | Updated caching logic to work with Home objects. |
| src/bolig_ping/init.py | Updated description for Home listings. |
| pyproject.toml | Updated project description to reflect Home listings. |
| README.md | Updated documentation from flat to home; minor typo issue. |
| CHANGELOG.md | Updated changelog with new property type feature. |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
--property-type(-t) option. The available property types areejerlejlighed,andelslejlighedandhouse. You can specify multiple property types with, e.g.,bolig-ping <other-arguments> -t ejerlejlighed -t house. It defaults toejerlejlighed, which is the only type that was previously supported.Fixed
message. Previously, it would just print the raw traceback.