Skip to content

Conversation

@saattrupdan
Copy link
Owner

@saattrupdan saattrupdan commented Apr 19, 2025

Added

  • Added the ability to search for different property types, with the new
    --property-type (-t) option. The available property types are ejerlejlighed,
    andelslejlighed and house. You can specify multiple property types with, e.g.,
    bolig-ping <other-arguments> -t ejerlejlighed -t house. It defaults to
    ejerlejlighed, which is the only type that was previously supported.

Fixed

  • Now catches when an invalid city name is provided, and returns a helpful error
    message. Previously, it would just print the raw traceback.

@saattrupdan saattrupdan requested a review from Copilot April 19, 2025 16:43
@saattrupdan saattrupdan self-assigned this Apr 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for multiple property types by refactoring all references from “flat” to “home” and adding a new CLI option for property types. Key changes include:

  • Renaming and updating data model and test names from Flat to Home.
  • Adding the new –property-type (–t) option to filter search queries.
  • Updating documentation, changelog, and email messaging to reflect the new property terminology.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_email.py Updated tests to use Home instead of Flat.
tests/test_data_models.py Updated test cases and descriptions from Flat to Home.
tests/test_cache.py Updated caching tests with Home references.
src/bolig_ping/scraper.py Updated scraping functionality to work with Home objects.
src/bolig_ping/email.py Updated email composition for Home listings.
src/bolig_ping/data_models.py Refactored Flat to Home and added property_type handling.
src/bolig_ping/cli.py Updated CLI options, including the new property type flag.
src/bolig_ping/cache.py Updated caching logic to work with Home objects.
src/bolig_ping/init.py Updated description for Home listings.
pyproject.toml Updated project description to reflect Home listings.
README.md Updated documentation from flat to home; minor typo issue.
CHANGELOG.md Updated changelog with new property type feature.

@saattrupdan saattrupdan changed the title Feat/add new property types Add new property types, catch invalid city names Apr 19, 2025
Co-authored-by: Copilot <[email protected]>
@saattrupdan saattrupdan merged commit e22b9a1 into main Apr 19, 2025
3 of 4 checks passed
@saattrupdan saattrupdan deleted the feat/add-new-property-types branch April 19, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants