-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flow examples #37
Conversation
build: update PRBMath build: add flow/lockup foundry profiles feat: implement a FlowUtilities library feat: implement flow creator contract refactor: rename v2 to lockup chore: add scripts in package json for the new profiles
3dcfadb
to
da161e5
Compare
build: install flow repo via package.json test: add tests for FlowStreamCreator test: add tests for FlowBatchable
@andreivladbrg this might need some refactor with the |
indeed it needs, will updated it also, since the repo is public now, it can be removed via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on Flow examples especially FlowUtilities
library. I have an idea for an example:
- An example to salaries to multiple people through a single contract.
Let me know what you think if it would be useful or an overkill for this repo? I was thinking of examples from the use case point of view. And this may be a useful for users.
b12104e
to
9fedb7a
Compare
Adding a note that after merging this PR, the links should be updated in sablier-labs/docs#186 |
yes, we should update them, also mentioned in the OP: ![]() |
well, the stream creator can be used for this case. e.g. |
polish code use the latest deployment
Fair point about using stream creator for salary example. But see my comment here. |
Should we merge it @andreivladbrg given we are going live in a few hours? |
we will need to update the links in |
Yes. We can do that after this is merged. |
Closes #36
Note: this PR merge must be synchronized with docs reference changes due to
v2
rename tolockup
(e.g. this one). Will work on that once you finish with your refactor @smol-ninja.The
flow
example contracts are represented by these 4:FlowBatchable
adjustRatePerSecondAndDeposit
,createMultiple
,createAndDepositViaBroker
etc.) to declare the calldata as bytes for multiple function calls into a single txFlowManager
FlowStreamCreator
FlowUtilities
rps
using a desired amount and duration.@sablier-labs/solidity lmk if you have anything else in mind, or if the current ones should suffice