Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner code review #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Partner code review #4

wants to merge 3 commits into from

Conversation

sadaf-Daneshgar
Copy link
Owner

@sadaf-Daneshgar sadaf-Daneshgar commented Jun 19, 2023

This milestone:

  • There aren't any new changes from the master branch just for creating this PR to have a code review.
  • I added all requirements base on the curriculum.
  • Dear @sonika I'm eagerly waiting for your constructive and positive feedbacks regarding to this project.

Thank you!

@Sonikak004
Copy link

Sonikak004 commented Jun 19, 2023

Hi @sadaf-Daneshgar , 👋
I'm sonika.

You have done a great job working on this milestone 💻 , there are some changes that you need to make based on clean code best practices. ♻️

Highlights

✅ Great use of GitHub flow. 💯
✅ Your project is documented professionally. 📜
✅ Great UI design. 💻

Required Changes ♻️

Check the comments under.

  • It would be good if you could HTML semantic tags like Header, Nav instead of div's in the above part of the code. 😄

    <div class="title">
    <label class="heading">Today's To Do</label>
    <button type="button">
    <i class="bi bi-arrow-repeat"></i>
    </button>
    </div>

  • You can give descriptive names to all the variables for more code readability.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

@sadaf-Daneshgar
Copy link
Owner Author

Hello @Sonikak004
Thank you for your nice suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants