Skip to content

tomli is integrated as tomllib since Python 3.11 #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a-detiste
Copy link

No description provided.

@dimpase
Copy link
Member

dimpase commented May 17, 2025

the minimum Python version we support is 3.11, so there is no need to special-case anything older

@a-detiste
Copy link
Author

Ok, I change

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why no tomllib in requirements.txt ? is it a part of standard Python now?

@a-detiste
Copy link
Author

Yes, exactly. It s a copy of tomli with another name.

@dimpase
Copy link
Member

dimpase commented May 18, 2025

the minimum Python version we support is 3.11, so there is no need to special-case anything older

oops, I am sorry, I messed up (confused sagemath/cysignals with sagemath/sage). cysignals should still work on python 3.9+, as you can see in https://github.com/sagemath/cysignals/blob/main/pyproject.toml

Thus, we still need to

import tomli as tomllib

on pythons older than 3.11.

@a-detiste
Copy link
Author

Ok, previous change was rebased in oblivion, will do it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants