Skip to content

Conversation

@user202729
Copy link
Contributor

See the newly added test, previously it segmentation faults.

the reason is the inner loop loop_over_rectangular_box_points accesses i_min = box_min[0] without any bound checking, this will segmentation fault if box_min is empty.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR (built with commit aed2017; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Traceback (most recent call last):
...
AssertionError
"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring says

* "X" -- polynomial, algebraic variety, or anything else that has a
  Jacobian elliptic curve

Is GF(11)['x,y'](3) a proper input?

Preventing segmentation fault even for improper inputs seems to be a good thing. But the "TEST" seems to be misplaced. A "TEST" may be added to src/sage/geometry/integral_points.pxi. Or, in my opinion, no "TEST" is acceptable since it is unlikely to break again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants