async project exec #7686
Merged
async project exec #7686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldschilly
force-pushed
the
api-project-exec-async-7666
branch
5 times, most recently
from
930eaaf to
d744c80
Compare
haraldschilly
force-pushed
the
api-project-exec-async-7666
branch
2 times, most recently
from
e0dd6ab to
8cb6d5b
Compare
haraldschilly
force-pushed
the
api-project-exec-async-7666
branch
4 times, most recently
from
984ea3f to
b4cca76
Compare
haraldschilly
force-pushed
the
api-project-exec-async-7666
branch
from
b4cca76 to
63ca2e9
Compare
haraldschilly
force-pushed
the
api-project-exec-async-7666
branch
12 times, most recently
from
5c482b9 to
f0b95f4
Compare
haraldschilly
force-pushed
the
api-project-exec-async-7666
branch
from
f0b95f4 to
3bd2865
Compare
haraldschilly
force-pushed
the
api-project-exec-async-7666
branch
3 times, most recently
from
eacec3f to
e9c8491
Compare
haraldschilly
added
PR-needs review
PR-work in progress
and removed
PR-work in progress
PR-needs review
labels
haraldschilly
force-pushed
the
api-project-exec-async-7666
branch
from
e9c8491 to
786bf1f
Compare
| @@ -20,12 +40,24 @@ export interface ExecuteCodeOptions { | |||
| env?: object; // if given, added to exec environment | |||
| aggregate?: string | number; // if given, aggregates multiple calls with same sequence number into one -- see @cocalc/util/aggregate; typically make this a timestamp for compiling code (e.g., latex). | |||
| verbose?: boolean; // default true -- impacts amount of logging | |||
| async_call?: boolean; // default false -- if true, return an ID and execute it asynchroneously | |||
There was a problem hiding this comment.
" asynchroneously" is not spelled right.
| job_id, | ||
| status: "running", | ||
| }; | ||
| asyncCache.set(job_id, started); |
There was a problem hiding this comment.
jonathan: you could use a third arg to set the timeout here to be bigger than opts.timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
{type: "blocking"}indicator to the response. I can't think of any reason why this is could become a problem.Checklist: