Skip to content

extract project/backend aspects of api-exec-await #7752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

haraldschilly
Copy link
Contributor

Description

This is just the project, backend and types aspect of #7722

The new code should be backwards compatible, but it's saner to do this in 2 phases and make sure there is either the old code (before the recent async changes) or the new code being used.

Checklist:

  • Testing instructions are provided, if not obvious
  • Release instructions are provided, if not obvious

@haraldschilly haraldschilly marked this pull request as ready for review August 12, 2024 12:39
@williamstein williamstein merged commit 32fe345 into master Aug 12, 2024
2 checks passed
@williamstein
Copy link
Contributor

I hit this test failure once on my laptop:

│ FAIL ./reuse-in-flight.test.ts (10.337 s)
│   ● reuseInFlight › different args
│     expect(received).toStrictEqual(expected) // deep equality
│     - Expected  - 1
│     + Received  + 1
│     @@ -4,8 +4,8 @@
│         0,
│         0,
│         0,
│         1,
│         1,
│     -   2,
│     +   1,
│         1,
│       ]
│       61 |     ]);
│       62 |
│     > 63 |     expect(res).toStrictEqual([0, 0, 0, 0, 0, 1, 1, 2, 1]);
│          |                 ^
│       64 |   });
│       65 |
│       66 |   test("ignoreSingleUndefined", async () => {
│       at Object.<anonymous> (reuse-in-flight.test.ts:63:17)

It worked when I tried again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants