Skip to content

remove html-minify-loader // take 2 #7972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

haraldschilly
Copy link
Contributor

@haraldschilly haraldschilly commented Oct 21, 2024

  • redoing static/webpack/npm: get rid of html-minify-loader #7953
  • ⚠️ this also deletes account.html and jupyter.html. I haven't found any references to these files and well, the first one is just trivial and seems to be pointless, and the second one must have been related to an older iteration, before the react jupyter implementation.
  • primary objective is to check that sagews is still working fine

so, with that, these template html files still end up in the body, just like before. I found no other html files referenced in the code.

Screenshot from 2024-10-21 15-42-53

@haraldschilly haraldschilly changed the title Rm load html take 2 remove html-minify-loader // take 2 Oct 21, 2024
@williamstein
Copy link
Contributor

i like this approach.

@haraldschilly haraldschilly marked this pull request as ready for review October 21, 2024 13:51
@williamstein williamstein merged commit f3fd7e5 into master Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants