[msyncd] Add method to enable/disable sync profiles for a specific service #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice Ensure the profile is created if it does not already exist. Fixes the issue where a service can be added later. Also ensures that only sync profiles for the specified service are affected when enabling or disabling it.
|
i doubt it is interesting to have this code shared , since we do use the "remove_service_name" in the template sync profile directly, probably not a universal solution |
|
Well, the question of having a profile matching a service, when a new service is added to the account is a good question. I've quickly looked into the patch and I agree that it may not be of general interest, but the previous question remains valid nonetheless. I'll try to think more about it, based on what you're proposing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method to enable/disable sync profiles for a specific service
Ensure the profile is created if it does not already exist.
Fixes the issue where a service can be added later. Also ensures that only sync profiles for the specified service are affected when enabling or disabling it.