Quickmozview landscape fixes #58
Open
+57
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added overrides for inherited API and lowercased + privatized the helper methods. There seemed to be a bit confusion over these, ScheduleWork() is a reimplemented method but wasn't declared virtual, ScheduleWorkLocal() is a helper but was marked virtual.
This almost worked but text selection (e.g. sailfish components-webview) was receiving wrong coordinates. Similar to QMozOpenGLWebPage before commit f492ed4.
mlehtima
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes at least text selection with components-webview / WebView. A bit similar to earlier done browser transpose() fix, but here the portrait assumptions and coordinate flipping went a bit further.
Also cleaned up the message pump a bit, separating better what's the inherited public api and what are the local helpers, etc.