[#15] Replace newlines with ZPL equivalent #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In FieldData, add an option to replace newlines `\n` with ZPL newline representation `\&`. Also update FieldBlock extension to use this option so that any usage of fieldBlock will automatically replace newlines.
jbduncan
reviewed
Sep 9, 2024
- Make newline replacement non-optional. It is very unlikely we want to allow newline `\n` characters in field data as this breaks ZPL output. - Remove explicit use of `LinkedHashMap` as the `parameters` type in favour of using just `Map`. - Add helper `addParameters` to make explicit that we want a `LinkedHashMap` to be used when adding parameters. This is to ensure key entry order is preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FieldData, add an option to replace newlines
\nwith ZPL newline representation\&.Also update FieldBlock extension to use this option so that any usage of fieldBlock will automatically replace newlines.