Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-50358 Responsiveness of Assignment and Chat Room tools #13237

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

i-a-m-s-k
Copy link
Contributor

Made the multiselect responsive for longer group names.

@csev csev requested a review from ottenhoff January 29, 2025 14:49
@ottenhoff
Copy link
Contributor

but now once you select a very long group, it goes wider than the screen.

@i-a-m-s-k
Copy link
Contributor Author

I'll check that, thanks for the review.

@i-a-m-s-k
Copy link
Contributor Author

@ottenhoff I have added a function that makes the button text constant and not replace it with the selected options (as seen previously). Please review it, thank you.

@ottenhoff
Copy link
Contributor

ottenhoff commented Feb 7, 2025

I don't know if this is an improvement or not. We can discuss on a core call.

Now, when editing an assignment, when i have several groups selected, here is what the user sees:

Screenshot 2025-02-07 at 11 34 08 AM

I think my vote is that this is not an improvement. "You must select" is telling me that I need to perform an action even though I have already selected groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants