SAK-50095 Discussion topic linking to GB automatically checks the box to add a task #13261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to add task in Dashboard Tasks widget
ern
changed the title
adrianfish
requested changes
Feb 3, 2025
| @@ -47,7 +47,8 @@ | |||
| var elems = document.getElementsByTagName('sakai-rubric-association'); | |||
| var forumAssignments = document.getElementById("revise:forum_assignments"); | |||
| const createTaskGroup = document.getElementById("revise:createTaskGroup"); | |||
| if (forumAssignments?.value && forumAssignments.value !== "Default_0") { | |||
| const isTasksWidgetAvailable = !!document.querySelector("sakai-tasks"); | |||
| if (forumAssignments?.value && forumAssignments.value !== "Default_0" && isTasksWidgetAvailable) { | |||
There was a problem hiding this comment.
Can forumAssignments be nullish here? If so, it may just make sense to return at the top of the method instead of using these if blocks.
There was a problem hiding this comment.
what about forumAssignments? That operator is checking for null
There was a problem hiding this comment.
If forumAssigments is crucial in this block of code, then why not exit the method early so no more dom queries have to happen. It would make the code clearer too, probably. Also, you can directly compare the optional chaining output using !==. undefined is a primitive so can be used in the equality statements.
| if (topicAssignments?.value && topicAssignments.value !== "Default_0") { | ||
| const isTasksWidgetAvailable = !!document.querySelector("sakai-tasks"); | ||
|
|
||
| if (topicAssignments?.value && topicAssignments.value !== "Default_0" && isTasksWidgetAvailable) { |
There was a problem hiding this comment.
Same question here, about topicAssignments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.