-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade PNPM to latest version #731
Open
NyanKiyoshi
wants to merge
5
commits into
saleor:main
Choose a base branch
from
NyanKiyoshi:deps/update-pnpm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,193
−4,885
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ec70a26
Upgrade PNPM to latest version
NyanKiyoshi e98cb7c
ci: read PNPM version from package.json
NyanKiyoshi 5d0fffb
ci: upgrade node.js version
NyanKiyoshi d32683e
ci: fix outdated PNPM setup action in release workflow
NyanKiyoshi 5e24640
ci: use .nvmrc file to specify node version
NyanKiyoshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,12 +15,10 @@ jobs: | |
| timeout-minutes: 10 | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: pnpm/[email protected] | ||
| - uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0 | ||
| - uses: actions/[email protected] | ||
| with: | ||
| version: 8 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16.x | ||
| node-version-file: ".nvmrc" | ||
| cache: 'pnpm' | ||
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
@@ -42,4 +40,4 @@ jobs: | |
| SALEOR_CLI_ENV: staging | ||
| RUN_FUNCTIONAL_TESTS: true | ||
| run: | | ||
| pnpm vitest run test/clear_cloud.test.ts | ||
| pnpm vitest run test/clear_cloud.test.ts | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,12 +5,10 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: pnpm/[email protected] | ||
| - uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0 | ||
| - uses: actions/[email protected] | ||
| with: | ||
| version: 8 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16.x | ||
| node-version-file: ".nvmrc" | ||
| cache: pnpm | ||
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
@@ -21,12 +19,10 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: pnpm/[email protected] | ||
| with: | ||
| version: 8 | ||
| - uses: actions/setup-node@v3 | ||
| - uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0 | ||
| - uses: actions/[email protected] | ||
| with: | ||
| node-version: 16.x | ||
| node-version-file: ".nvmrc" | ||
| cache: 'pnpm' | ||
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
@@ -37,12 +33,10 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: pnpm/[email protected] | ||
| with: | ||
| version: 8 | ||
| - uses: actions/setup-node@v3 | ||
| - uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0 | ||
| - uses: actions/[email protected] | ||
| with: | ||
| node-version: 16.x | ||
| node-version-file: ".nvmrc" | ||
| cache: pnpm | ||
| - uses: actions/cache@v3 | ||
| with: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,12 +21,10 @@ jobs: | |
| run: | | ||
| git config user.name "${GITHUB_ACTOR}" | ||
| git config user.email "${GITHUB_ACTOR}@users.noreply.github.com" | ||
| - uses: pnpm/[email protected] | ||
| - uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0 | ||
| - uses: actions/[email protected] | ||
| with: | ||
| version: 8 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16 | ||
| node-version-file: ".nvmrc" | ||
| cache: pnpm | ||
| - name: Install the dependencies | ||
| run: pnpm install | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,12 +19,10 @@ jobs: | |
| run: | | ||
| git config user.name "${GITHUB_ACTOR}" | ||
| git config user.email "${GITHUB_ACTOR}@users.noreply.github.com" | ||
| - uses: pnpm/[email protected] | ||
| - uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0 | ||
| - uses: actions/[email protected] | ||
| with: | ||
| version: 8 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16.x | ||
| node-version-file: ".nvmrc" | ||
| cache: pnpm | ||
| - name: Install the dependencies | ||
| run: pnpm install | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,12 +15,10 @@ jobs: | |
| timeout-minutes: 60 | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: pnpm/[email protected] | ||
| - uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0 | ||
| - uses: actions/[email protected] | ||
| with: | ||
| version: 8 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16.x | ||
| node-version-file: ".nvmrc" | ||
| cache: 'pnpm' | ||
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
@@ -71,4 +69,4 @@ jobs: | |
| SLACK_COLOR: ${{ job.status }} | ||
| SLACK_TITLE: "Functional tests failed" | ||
| SLACK_MESSAGE: "https://github.com/saleor/saleor-cli/actions/workflows/tests-nightly.yml" | ||
| MSG_MINIMAL: true | ||
| MSG_MINIMAL: true | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 18 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -120,8 +120,10 @@ | |
| "yargs": "^17.7.2" | ||
| }, | ||
| "engines": { | ||
| "node": "^16 || ^18 || ^20" | ||
| "node": "^18 || ^20", | ||
| "pnpm": ">=9.0.0 <10.0.0" | ||
| }, | ||
| "packageManager": "[email protected]", | ||
| "pnpm": { | ||
| "overrides": { | ||
| "uuid": "8.3.2" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you switch to node 22 add here
|| ^22There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer not to do so as it's uncertain whether Node.js v22 will work properly, thus it introduces more risks and thus more work (scope of the PR is only to upgrade PNPM version in order to be able to scan for license compliance, Node.js v16 isn't supported in latest PNPM version but works properly in v18)