Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix salesagility#10630 - Scheduled task “Run Email Reminder Notifications” does not run when deleting a person #10631

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

SinergiaCRM
Copy link
Contributor

Fixing #10630

Description

It has been found that when creating a meeting with reminders, both pop-up and email reminders, and a person/user is removed before the scheduled “Run Email Reminder Notifications” task is executed, the execution fails, causing the task to stall and from that point on, no reminders will be sent.
In addition, if the task has been stalled for a long time, meetings with past dates are sent.

Motivation and Context

  1. A condition has been added that if the task has been stuck for a long time and the reminder has already passed (meeting start date, example: 06/16/2022 9:00), no reminder will be sent to the attendees of the last meeting.
  2. A condition has been added that if the person is deleted, no attempt to send an email will be made and the task will continue to be executed.

How To Test This

Deleted person

  1. Create a meeting, adding a mail reminder to the attendees.
  2. Save and send invitations.
  3. Delete the person/user before executing the scheduled task “Run Email Reminder Notifications”.
  4. See in the meeting that the person is listed as “UNKNOWN”.
  5. Execute the “Run Email Reminder Notifications” task.
  6. Verify that the reminder email arrives to the invitees, except for the deleted person, and to the meeting creator.
  7. Also, check that the task has been executed correctly.

Past meeting

  1. Create a past meeting, adding a mail reminder to attendees.
  2. Save and send invitations.
  3. Execute the task “Run Email Reminder Notifications”.
  4. Check that the reminder email does not arrive, neither to any of the invitees nor to the meeting creator.
  5. Also, check that the task has been executed correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

…ions” does not run when deleting a person
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant