Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some failed attempts at #16 publishing as a PR just to have a record of what I have tried.
This PR works as expected if you specify tool runtime in your run command:
But does not work:
java_runtime_versionis used, which I would expect to workIf we can find a solution this should only occur in a major upgrade in rules_spring because of the many cases that may break. I am personally confused by all of the bugs and changes in the java toolchain resolution in Bazel over the years, and changing anything in rules_spring that touches that should be done with great care.
java_binarycan no longer be used in$(location)expansions bazelbuild/bazel#21915We offer a set of options for specifying the JVM used in Bazel run, hopefully you can find an option that works for you.