Refactoring: Move allowed characters out of hardcoded regex

This refactoring will allow for an easier addition/deletion of allowed characters, without directly manipulating the regular expression.
salesking · kiriakosv · Mar 13, 2021 · Mar 13, 2021 · bdd9ee6a0b2943d035f710b12751715df9ca3cc4
commit bdd9ee6a0b2943d035f710b12751715df9ca3cc4
diff --git a/lib/misc/allowed_chars.txt b/lib/misc/allowed_chars.txt
@@ -0,0 +1 @@
+abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ÄÖÜäöüß&*$% ':?,-(+.)/
diff --git a/lib/sepa_king/converter.rb b/lib/sepa_king/converter.rb
@@ -15,6 +15,8 @@ def convert(*attributes, options)
     end
 
     module InstanceMethods
+      ALLOWED_CHARS = Regexp.escape(File.read('lib/misc/allowed_chars.txt')).freeze
+
       def convert_text(value)
         return unless value
 
@@ -29,7 +31,7 @@ def convert_text(value)
           gsub(/\n+/,' ').
 
           # Remove all invalid characters
-          gsub(/[^a-zA-Z0-9ÄÖÜäöüß&*$%\ \'\:\?\,\-\(\+\.\)\/]/, '').
+          gsub(/[^#{ALLOWED_CHARS}]/, '').
 
           # Remove leading and trailing spaces
           strip
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789ÄÖÜäöüß&*$% ':?,-(+.)/