Feature | Refactor merge logic for recursive and safe array merging #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced `merge` methods to support recursive merging with proper handling of associative and sequential arrays. Introduced helper methods to ensure safe merging and added tests to validate the behavior. This improves flexibility when working with complex nested data structures.
The 'first_name' field was added to the 'profile' array in the test data to better align with expected data structures. This ensures the tests accurately reflect real-world usage scenarios.
mfrieswyk
changed the title
|
This would be very helpful for some of the more complex payloads we're sending with Saloon now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced
mergemethods to support recursive merging with proper handling of associative and sequential arrays. Introduced helper methods to ensure safe merging and added tests to validate the behavior. This improves flexibility when working with complex nested data structures.This allows a more flexible developer experience, whereby you can merge a modified body back into the request and all matching nodes will be updated while any new nodes are added.