Skip to content

implement Update for OrderMap and OrderSet #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaReiser merged 1 commit into from
Dec 4, 2025
Merged

implement Update for OrderMap and OrderSet #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ hashbrown = "0.15"
hashlink = "0.10"
indexmap = "2"
intrusive-collections = "0.9.7"
ordermap = "1"
Copy link
Member

@Veykril Veykril Dec 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a feature gated dependency at the very least

Copy link
Contributor Author

@oconnor663 oconnor663 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going off how indexmap was handled, but now that I look again I guess that's because it's used internally and not purely imported for trait impls. I'll put up a followup PR.

Copy link
Contributor

@MichaReiser MichaReiser Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry, I missed this. Thanks @Veykril

Copy link
Contributor Author

@oconnor663 oconnor663 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1034

parking_lot = "0.12"
portable-atomic = "1"
rustc-hash = "2"
Expand Down
21 changes: 21 additions & 0 deletions src/update.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,27 @@ where
}
}

unsafe impl<K, V, S> Update for ordermap::OrderMap<K, V, S>
where
K: Update + Eq + Hash,
V: Update,
S: BuildHasher,
{
unsafe fn maybe_update(old_pointer: *mut Self, new_map: Self) -> bool {
maybe_update_map!(old_pointer, new_map)
}
}

unsafe impl<K, S> Update for ordermap::OrderSet<K, S>
where
K: Update + Eq + Hash,
S: BuildHasher,
{
unsafe fn maybe_update(old_pointer: *mut Self, new_set: Self) -> bool {
maybe_update_set!(old_pointer, new_set)
}
}

unsafe impl<K, V> Update for BTreeMap<K, V>
where
K: Update + Eq + Ord,
Expand Down
Loading