Allow parent fields #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Сделаете отдельным pull request тестов на phpbench? |
Честно говоря еще не приходилось работать с phpbench, если будет время могу попробовать. |
|
Там всё не очень сложно. Штука хорошая, советую освоить, пригодится. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добрый день, Александр!
Позволил себе изменить ваш класс Hydrator для своих нужд.
Ввел возможность работы с унаследованными приватными полями. Попутно немного зарефакторил (hydrate, hydrateInto - убрал дублирование).
Тесты проходят, дописал 2 дополнительных с дочерними классами.
Производительность конечно пострадала, т.к. теперь для каждого поля вычисляется ReflectionClass, насколько не измерял.