feat: Change health connection to SSE #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TKussel
previously approved these changes
Jan 15, 2025
|
Have to double check that. Besides I think I have a few new ideas on how to go about it having done something similar in a private project 😄 |
|
This is now stacked on top of #226 so I can do further refactors here |
Threated
force-pushed
the
health-sse
branch
4 times, most recently
from
f53fd2c to
1b7d1e0
Compare
|
Have not tested this yet but this should solve a lot of the flaky problems we have and should still be compatible with beamctls health check as it only expects |
TKussel
requested changes
Jan 29, 2025
Threated
commented
Jan 29, 2025
TKussel
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.