Simplify tower types #11
Conversation
| xmlchange, | ||
| ) | ||
| def __init__(self, *args, **kwargs): | ||
| super().__init__("NEON", *args, **kwargs) |
There was a problem hiding this comment.
This would indeed be a lot cleaner... Just for my own knowledge, if the args are slightly different between the two, would it still be helpful to describe the arguments and types/definitions here, or is that better suited for the tower_site class with specifications on what applies to neon/plumber listed there?
There was a problem hiding this comment.
I think it would be best for any differences to be described there, yeah, since that's where the differences would actually manifest. Any notes here would need to be kept up-to-date with changes in TowerSite.
| @@ -120,9 +120,9 @@ def test_plumber_site(self): | |||
| # assert that AR-SLu directories were created during setup | |||
| self.assertTrue("AR-SLu" in glob.glob(self._tempdir + "/AR-SLu*")[0]) | |||
|
|
|||
| def test_xmlchange_neon(self): | |||
| def test_xmlchange(self): | |||
There was a problem hiding this comment.
This would also make testing take less time! :)
| finidat = "dummy_finidat" | ||
|
|
||
| # try to create site | ||
| invalid_type = "INVALIDTYPE" |
There was a problem hiding this comment.
I could also see this being helpful in the future if anyone wanted to create their own class type.
There was a problem hiding this comment.
That's what I was thinking! Although I've been having second thoughts—I'm not sure how useful this invalid type check really is. It'd be easier for someone to make their own new type if they didn't have to add it to the list of accepted types.
There was a problem hiding this comment.
It seems that if it's really clear where the type is added, and if that makes it easier to track down what other things need to be done to add a new type, it could be useful. Also, realistically, I might be somewhat surprised if more types are added given the lack of future funding on this project, so maybe this isn't a major concern one way or another right now.
There was a problem hiding this comment.
Nice, thanks. I'll get rid of it, then.
- Get rid of invalid site type check.
|
Replacing with ESCOMP#2969. |
Description of changes
Simplifies child types of
TowerSite(NeonSite,Plumber2Site).Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed: None
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
test_sys_run_tower.py