Another sprockets dependency PR! #359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While restricting to sprockets 3 in Gemfile, since our CI does not currently work with sprockets 4
Now our installer -- which only works with sprockets 3 at present -- will still work. But the local app is free to change/erase this and upgrade to sprockets 4 itself. With the sprockets 3 requirement in our .gemspec, the local app was not
This makes CI work, it is unclear why. It was not necessary to succesfully run tests on codebase locally. It is irrelevant to apps actually using browse_everything as a gem, doesn't change the situation for them at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's a rebased version of #345 but I moved it to a new branch in case we want to try some other changes.