Merge pull request #6490 from samvera/updates_stats_controller_spec

Marks test suite as ActiveFedora-only, since controller calls to multiple classes not Valkyrized.

spec/controllers/hyrax/stats_controller_spec.rb

@@ -7,69 +7,135 @@
     allow_any_instance_of(User).to receive(:groups).and_return([])
   end
   routes { Hyrax::Engine.routes }
-  describe '#file' do
-    let(:file_set) { create(:file_set, user: user) }
 
-    context 'when user has access to file' do
-      before do
-        sign_in user
-        request.env['HTTP_REFERER'] = 'http://test.host/foo'
+  shared_context('with user signed in and http referer set') do
+    before do
+      sign_in user
+      request.env['HTTP_REFERER'] = 'http://test.host/foo'
+    end
+  end
+
+  def test_loading_file_set_with_user_access # rubocop:disable Metrics/AbcSize
+    expect(Hyrax::FileUsage).to receive(:new).with(file_set.id).and_return(usage)
+    expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
+    expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+    expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.my.works'), Hyrax::Engine.routes.url_helpers.my_works_path(locale: 'en'))
+    expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.file_set.browse_view'), Rails.application.routes.url_helpers.hyrax_file_set_path(file_set, locale: 'en'))
+    get :file, params: { id: file_set }
+    expect(response).to be_successful
+    expect(response).to render_template('stats/file')
+  end # rubocop:enable Metrics/AbcSize
+
+  def test_loading_public_file_no_user_signed_in
+    get :file, params: { id: file_set }
+    expect(response).to be_successful
+    expect(response).to render_template('stats/file')
+  end
+
+  def test_loading_file_user_no_access_signed_in
+    get :file, params: { id: file_set }
+    expect(response).to redirect_to(Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
+  end
+
+  context 'with ActiveFedora objects', :active_fedora do
+    describe '#file' do
+      let(:file_set) { create(:file_set, user: user) }
+
+      context 'when user has access to file' do
+        include_context 'with user signed in and http referer set'
+
+        it 'renders the stats view' do
+          test_loading_file_set_with_user_access
+        end
+      end
+
+      context "user is not signed in but the file is public" do
+        let(:file_set) { create(:file_set, :public, user: user) }
+
+        it 'renders the stats view' do
+          test_loading_public_file_no_user_signed_in
+        end
       end
 
+      context 'when user lacks access to file' do
+        let(:file_set) { create(:file_set) }
+
+        before { sign_in user }
+
+        it 'redirects to root_url' do
+          test_loading_file_user_no_access_signed_in
+        end
+      end
+    end
+
+    describe 'work' do
+      let(:work) { create(:generic_work, user: user) }
+
+      include_context 'with user signed in and http referer set'
+
       it 'renders the stats view' do
-        expect(Hyrax::FileUsage).to receive(:new).with(file_set.id).and_return(usage)
+        expect(Hyrax::Analytics).to receive(:daily_events_for_id).with(work.id, 'work-view').and_return([])
+        expect(Hyrax::Analytics).to receive(:daily_events_for_id).with(work.id, 'file-set-in-work-download').and_return([])
         expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
-        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
         expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.my.works'), Hyrax::Engine.routes.url_helpers.my_works_path(locale: 'en'))
-        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.file_set.browse_view'), Rails.application.routes.url_helpers.hyrax_file_set_path(file_set, locale: 'en'))
-        get :file, params: { id: file_set }
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Test title', main_app.hyrax_generic_work_path(work, locale: 'en'))
+        get :work, params: { id: work }
         expect(response).to be_successful
-        expect(response).to render_template('stats/file')
+        expect(response).to render_template('stats/work')
       end
     end
+  end
 
-    context "user is not signed in but the file is public" do
-      let(:file_set) { create(:file_set, :public, user: user) }
+  # NOTE: The tests below do not function as expected due to the classes involving Stats not being Valkyrized.
+  #   See spec/presenters/hyrax/file_usage_spec.rb for an example.
+  context 'with Valkyrie objects' do
+    describe '#file' do
+      let(:file_set) { valkyrie_create(:hyrax_file_set, depositor: user.user_key) }
 
-      it 'renders the stats view' do
-        get :file, params: { id: file_set }
-        expect(response).to be_successful
-        expect(response).to render_template('stats/file')
+      context 'when user has access to file' do
+        include_context 'with user signed in and http referer set'
+
+        xit 'renders the stats view' do
+          test_loading_file_set_with_user_access
+        end
       end
-    end
 
-    context 'when user lacks access to file' do
-      let(:file_set) { create(:file_set) }
+      context "user is not signed in but the file is public" do
+        let(:file_set) { valkyrie_create(:hyrax_file_set, :public, depositor: user.user_key) }
 
-      before do
-        sign_in user
+        xit 'renders the stats view' do
+          test_loading_public_file_no_user_signed_in
+        end
       end
 
-      it 'redirects to root_url' do
-        get :file, params: { id: file_set }
-        expect(response).to redirect_to(Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
+      context 'when user lacks access to file' do
+        let(:file_set) { valkyrie_create(:hyrax_file_set) }
+
+        before { sign_in user }
+
+        xit 'redirects to root_url' do
+          test_loading_file_user_no_access_signed_in
+        end
       end
     end
-  end
 
-  describe 'work' do
-    let(:work) { create(:generic_work, user: user) }
+    describe 'work' do
+      let(:work) { valkyrie_create(:monograph, depositor: user.user_key) }
 
-    before do
-      sign_in user
-      request.env['HTTP_REFERER'] = 'http://test.host/foo'
-    end
+      include_context 'with user signed in and http referer set'
 
-    it 'renders the stats view' do
-      expect(Hyrax::Analytics).to receive(:daily_events_for_id).with(work.id, 'work-view').and_return([])
-      expect(Hyrax::Analytics).to receive(:daily_events_for_id).with(work.id, 'file-set-in-work-download').and_return([])
-      expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
-      expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.my.works'), Hyrax::Engine.routes.url_helpers.my_works_path(locale: 'en'))
-      expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
-      expect(controller).to receive(:add_breadcrumb).with('Test title', main_app.hyrax_generic_work_path(work, locale: 'en'))
-      get :work, params: { id: work }
-      expect(response).to be_successful
-      expect(response).to render_template('stats/work')
+      xit 'renders the stats view' do
+        expect(Hyrax::Analytics).to receive(:daily_events_for_id).with(work.id, 'work-view').and_return([])
+        expect(Hyrax::Analytics).to receive(:daily_events_for_id).with(work.id, 'file-set-in-work-download').and_return([])
+        expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.my.works'), Hyrax::Engine.routes.url_helpers.my_works_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Test title', main_app.hyrax_monograph_path(work, locale: 'en'))
+        get :work, params: { id: work }
+        expect(response).to be_successful
+        expect(response).to render_template('stats/work')
+      end
     end
   end
 end