Skip to content

Commit

Permalink
Revert "Attempting to quash SQLite3::BusyException"
Browse files Browse the repository at this point in the history
This reverts commit 00316d0.

Based on CircleCI's response, instead of one of the builds fail, there
were failures of three of the builds. Two of which were
SQLite3::BusyException, and the second a UI test that could've masked
the busy exception.

I believe we need to be looking to switching from SQLite in CI to
Postgresql or MySQL. This will require forking logic, as we have
traditionally allowed SQLite to work for localized development and
testing (one simple dependency in an otherwise baroque labyrinth of
heavy JAVA-esque dependencies).
  • Loading branch information
jeremyf authored and Tom Johnson committed Feb 3, 2020
1 parent 00316d0 commit 977e2d0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 11 deletions.
1 change: 0 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ jobs:
environment:
RAILS_VERSION: << parameters.rails_version >>
NOKOGIRI_USE_SYSTEM_LIBRARIES: true
RAILS_MAX_THREADS: 50
steps:
- samvera/cached_checkout
- samvera/bundle_for_gem:
Expand Down
2 changes: 1 addition & 1 deletion .regen
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6
5
9 changes: 0 additions & 9 deletions tasks/hyrax_dev.rake
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,6 @@ if Gem.loaded_specs.key? 'engine_cart'
puts 'Creating default collection type...'
EngineCart.within_test_app do
raise "EngineCart failed on with: #{$?}" unless system "bundle exec rake hyrax:default_collection_types:create"

# Replace the default sqlite timeout to 15000 (which should triple the timeout). Based on some
# googling, this may help address the "ActiveRecord::StatementInvalid:SQLite3::BusyException:"
# exception that is occassionally breaking the build.
database_yml_content = File.read("config/database.yml")
new_database_yml_content = database_yml_content.gsub(/timeout: +(\d+)/, 'timeout: 15000')
File.open("config/database.yml", "w+") do |f|
f.puts new_database_yml_content
end
end
end
end
Expand Down

0 comments on commit 977e2d0

Please sign in to comment.