Modifying engine cart CI build parameterization #4256
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
force-pushed
the
removing-engine-cart-template
branch
4 times, most recently
from
059d926 to
f42f550
Compare
At present, EngineCart's parsing of `.engine_cart.yml` will overwrite the `ENGINE_CART_RAILS_OPTIONS` set in CircleCI (see [cbeer/engine_cart/102][1] for some details). The present overwrite behavior is reasonable. As the removed `.engine_cart.yml` targeted pre-Rails 5 behavior, I opted to remove it. In doing so, this would now "activate" the `.circleci/config.yml` declaration of `ENGINE_CART_RAILS_OPTIONS`. As we have coffee script in Hyrax (for better or worse) and we have ActionCable usage, I needed to revisit the now activated parameters. The parameters to which I changed are the defaults of EngineCart (as of this PR). Note: This is in preparation for allowing PostgreSQL as the database for CircleCI. As this impacts the `.internal_test_app` generation, I also needed to bump the Regen number. TL;DR: A 4 year old file that we no longer need is silently trampling on a CI variable. That CI variable has likely not been used. It now will be used, but needed modifications to reflect that usage. _I hope this works, as iterating on the CI process is always time consuming as it requires coordination of remote resources._ [1]:cbeer/engine_cart#102
jeremyf
force-pushed
the
removing-engine-cart-template
branch
from
f42f550 to
2d2dcf6
Compare
|
@jeremyf When this gets merged, will people have to regenerate their internal_test_apps? Just in case I get to doing some work at some point in time this week. |
|
You will not need to regenerate your internal test app once this is merged.
It's just cleaning up and aligning explicitly what was implicitly
happening.
…On Tue, Feb 4, 2020, 4:33 PM Brandon R. Straley ***@***.***> wrote:
@jeremyf <https://github.com/jeremyf> When this gets merged, will people
have to regenerate their internal_test_apps? Just in case I get to doing
some work at some point in time this week.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4256?email_source=notifications&email_token=AAAAQUVJLOU6FO3ACXKI2UTRBHNL3A5CNFSM4KP3JQC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZIR7Q#issuecomment-582125822>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAQUWPWASQMWBCGAHYTE3RBHNL3ANCNFSM4KP3JQCQ>
.
|
cjcolvar
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, EngineCart's parsing of
.engine_cart.ymlwill overwritethe
ENGINE_CART_RAILS_OPTIONSset in CircleCI (seecbeer/engine_cart/102 for some details). The present overwrite
behavior is reasonable. As the removed
.engine_cart.ymltargetedpre-Rails 5 behavior, I opted to remove it.
In doing so, this would now "activate" the
.circleci/config.ymldeclaration of
ENGINE_CART_RAILS_OPTIONS. As we have coffee script inHyrax (for better or worse) and we have ActionCable usage, I needed to
revisit the now activated parameters.
Note: This is in preparation for allowing PostgreSQL as the database
for CircleCI.
As this impacts the
.internal_test_appgeneration, I also needed tobump the Regen number.
TL;DR: A 4 year old file that we no longer need is silently trampling
on a CI variable. That CI variable has likely not been used. It now will
be used, but needed modifications to reflect that usage.
I hope this works, as iterating on the CI process is always time
consuming as it requires coordination of remote resources.
@samvera/hyrax-code-reviewers