-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create google analytics 4 compatibility #6815
Conversation
Test Results 9 files ±0 9 suites ±0 16m 49s ⏱️ -6s Results for commit 6a1d0ac. ± Comparison against base commit 334d9ad. This pull request removes 97 and adds 93 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
@@ -154,6 +154,11 @@ def total_visitors(period = 'month', date = 'today') | |||
response["nb_visits_returning"].to_i + response["nb_visits_new"].to_i | |||
end | |||
|
|||
# TODO implement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't fix Matomo for this release, but I honestly think that this may be the only part that needs to be updated for Matomo 4 to work again. There is another task for adding Matomo 5
Fixes
Fixes #5970, #5963, and #5818 and brings GA4 analytics in to the fold. Reports are fixed to render and GA4 tracking now actually records the right information.
Summary
Present tense short summary (50 characters or less)
Guidance for testing, such as acceptance criteria or new user interface behaviors:
GOOGLE_ANALYTICS_ID
GOOGLE_ANALYTICS_PROPERTY_ID
GOOGLE_ACCOUNT_JSON
Changes proposed in this pull request:
@samvera/hyrax-code-reviewers