Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use released nulldb gem #6995

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Use released nulldb gem #6995

merged 2 commits into from
Feb 5, 2025

Conversation

dlpierce
Copy link
Member

Use the released version of activerecord-nulldb-adapter gem that includes the branch we were using via git.

@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Jan 30, 2025
Copy link

github-actions bot commented Jan 30, 2025

Test Results

    13 files  ±    0      13 suites  +1   2h 50m 1s ⏱️ + 5m 42s
 6 833 tests +   25   6 534 ✅ +   26  299 💤 ± 0  0 ❌  - 1 
18 101 runs  +1 103  17 624 ✅ +1 093  477 💤 +11  0 ❌  - 1 

Results for commit 92c68a2. ± Comparison against base commit 21c5420.

This pull request removes 335 and adds 360 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f053def4c48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f36ddad6f40>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f053d943998>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f36ddb44d88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 0d7296c4-ba4c-4e9d-85fe-6dd9985fbf39
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: b1160db0-9869-4b72-998a-2f69acd0b6ce
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: ae1f2121-42f8-46d2-8d11-760fe08a1e31
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: d5d38079-0be3-4761-93d8-9a6188ce5c73
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 4252602d-209d-4fd7-ae58-f84987567c8e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: d4bde460-5e45-4c2b-becd-914b46f6847e
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f29732fa3c0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f359cac3fe0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007ff7ab055c80>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f29733ce620>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f359cabd5c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007ff7ab03dd60>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: dd2dc7bf-0f1f-4c6f-b1c9-acdb07ef82cb
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 0f87e2cd-c50e-409b-aa1a-18ca6fe21d1a
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: f4936f2f-df3f-462c-b83a-cf418dcdcf57
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 4199e098-cf79-42fe-bc95-3c68f5a5f987
…

♻️ This comment has been updated with latest results.

@cjcolvar cjcolvar merged commit 2e4dc49 into main Feb 5, 2025
17 checks passed
@cjcolvar cjcolvar deleted the nulldb-update branch February 5, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants