Skip to content

Conversation

@ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Sep 15, 2025

Warn batch upload is not compatible with flex

0b372ee

Batch upload and valkyrized works are incompatible. We will add help text to warn the user of this case: #7185

image

Related issues:

Batch upload and valkyrized works are incompatible. We will add help text to warn the user of this case: #7185
@ShanaLMoore ShanaLMoore force-pushed the cherry-pick-batch-upload-warning branch from b1a6c8a to 51e2918 Compare September 15, 2025 22:38
@github-actions
Copy link

Test Results

    13 files  ±0      13 suites  ±0   2h 48m 28s ⏱️ - 1m 22s
 6 905 tests ±0   6 599 ✅ ±0  306 💤 ±0  0 ❌ ±0 
18 340 runs  ±0  17 839 ✅ ±0  501 💤 ±0  0 ❌ ±0 

Results for commit 51e2918. ± Comparison against base commit 5b995db.

This pull request removes 365 and adds 365 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f24f7d47088>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fcc00389b08>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007feb70200018>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f24f81e17d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fcc001a3c08>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007feb6ecf5510>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 35eedf66-7148-49b6-a7c6-a48197e6b7bb
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 43b7ccc9-6c53-4a6d-9175-991a25fb64ff
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: b251b74c-b022-42b8-9041-7813dfcf9b3b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 5e263d7c-dc50-4e2d-a023-fe12b796f5de
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f8c10e63720>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f9e37a23988>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa18baceb10>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f8c10f73340>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f9e37a371e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa18ba3b400>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 17a5ae0b-c4cd-4778-8c78-436df5cc63b3
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 8a6265df-7bc5-45fd-a95a-9d8a0dfeff71
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: dbee63f3-c00f-4e62-94c7-b47390cc9fd6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 2837893d-c8b2-4066-aa66-33a37115b244
…

@orangewolf orangewolf marked this pull request as draft September 16, 2025 17:06
feature :batch_upload,
default: false,
description: "Enable uploading batches of works"
description: "Enable uploading batches of works. <br /><strong>WARNING:</strong> This feature is not compatible with flexible metadata.".html_safe
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this matches what was committed in 5.0-flexible

feature :batch_upload,
default: false,
description: "Enable uploading batches of works"
description: "Enable uploading batches of works. <br /><strong>WARNING:</strong> This feature is not compatible with flexible metadata.".html_safe
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "Enable uploading batches of works. <br /><strong>WARNING:</strong> This feature is not compatible with flexible metadata.".html_safe
description: "This functionality has been deprecated. Please use the bulk importer feature (Bulkrax) to perform this function moving forward."

@ShanaLMoore ShanaLMoore changed the title Warn batch upload is not compatible with flex Warn batch upload is not compatible with 6.2 Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants