⚙️ disable batch upload feature main #7202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 13 files ±0 13 suites ±0 2h 49m 25s ⏱️ - 4m 43s Results for commit 9f83c59. ± Comparison against base commit 23613bb. This pull request removes 360 and adds 360 tests. Note that renamed tests count towards both.This pull request skips 2 tests.♻️ This comment has been updated with latest results. |
sjproctor
force-pushed
the
i479-disable-batch-upload-feature-main
branch
from
16c0505 to
2318b0a
Compare
This commit prevents admin users from enabling batch_upload in settings. This addresses the issue that batch uploads and Valkyrized works are incompatible. The current Batch Add uses a fake Active Fedora form with fixed terms that ignore the selected work type, causing Valkyrie validations to fail (especially on 6.2). It was determined that fixing this issue is low-priority compared to general Bulkrax improvements. To ensure users are not enabling broken features, batch_upload is disabled until further decisions are made. Ref: - notch8/palni_palci_knapsack#479
The longer explanation about the disabled feature and accompanying URL causes a long line error in Rubocop. Ignoring the offense. Ref: - notch8/palni_palci_knapsack#479
Batch uploads have been disabled since batch uploads and Valkyrized works are incompatible. The current Batch Add uses a fake Active Fedora form with fixed terms that ignore the selected work type, causing Valkyrie validations to fail (especially on 6.2). It was determined that fixing this issue is low-priority compared to general Bulkrax improvements. This commit skips the batch_upload tests until further decisions are made. Ref: - #7185 - notch8/palni_palci_knapsack#479
sjproctor
force-pushed
the
i479-disable-batch-upload-feature-main
branch
from
2318b0a to
9f83c59
Compare
Contributor
randalldfloyd
left a comment
randalldfloyd
left a comment
There was a problem hiding this comment.
This solution is solid and it tests out for me locally; but we're going to defer to product owners long enough to come to a consensus on if it should be disabled in Hyrax. So I'll wait to merge to see how that goes.
Author
|
@randalldfloyd Thanks! Sounds good to me. I wanted to document the change since we added it to 5.0-flexible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This commit prevents admin users from enabling batch_upload in settings.
This addresses the issue that batch uploads and Valkyrized works are
incompatible. The current Batch Add uses a fake Active Fedora form with
fixed terms that ignore the selected work type, causing Valkyrie
validations to fail (especially on 6.2).
It was determined that fixing this issue is low-priority compared to
general Bulkrax improvements. To ensure users are not enabling broken
features, batch_upload is disabled until further decisions are made.
Ref:
Type of change (for release notes)
Add an appropriate
notes-*label to the PR (or indicate here) that classifies this change.Choose from:
notes-majorMajor Changes (Potentially breaking changes)notes-minorNew Features that are backward compatiblenotes-deprecationDeprecationsnotes-bugfixBug Fixesnotes-valkyrieValkyrie Progressnotes-docsDocumentationnotes-containerContainerization related (Docker, Helm, etc)@samvera/hyrax-code-reviewers