-
Notifications
You must be signed in to change notification settings - Fork 131
Draft - Rails 8 #7233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
randalldfloyd
wants to merge
4
commits into
main
Choose a base branch
from
rails-8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Draft - Rails 8 #7233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 13 files ±0 13 suites ±0 2h 47m 11s ⏱️ - 1m 48s For more details on these failures, see this check. Results for commit a009abc. ± Comparison against base commit b8d73a4. This pull request removes 358 and adds 359 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7214
This draft PR is a starting point for Rails 8 support. It has gemspec overrides to use core component branches that allow Rails 8. All of the test apps build and run successfully at Rails 8 with those overrides and a handful of initial fixes.
Currently, the gemspec uses a named branch (
rails-8) in core components; this was done so that the test apps will build/run, which will enable specs to be worked on in parallel with core component updates.Core components are currently awaiting releases so that the aforementioned overrides can be undone. So full Rails 8 compatibility should be possible by merging/releasing in the following in order:
samvera/hydra-head#564
samvera/hydra-head#565
samvera/hydra-derivatives#266
samvera/hydra-derivatives#267
samvera/hydra-works#399
samvera/hydra-editor#227