Skip to content

Conversation

@randalldfloyd
Copy link
Contributor

@randalldfloyd randalldfloyd commented Oct 7, 2025

#7214

This draft PR is a starting point for Rails 8 support. It has gemspec overrides to use core component branches that allow Rails 8. All of the test apps build and run successfully at Rails 8 with those overrides and a handful of initial fixes.

Currently, the gemspec uses a named branch (rails-8) in core components; this was done so that the test apps will build/run, which will enable specs to be worked on in parallel with core component updates.

Core components are currently awaiting releases so that the aforementioned overrides can be undone. So full Rails 8 compatibility should be possible by merging/releasing in the following in order:

samvera/hydra-head#564
samvera/hydra-head#565
samvera/hydra-derivatives#266
samvera/hydra-derivatives#267
samvera/hydra-works#399
samvera/hydra-editor#227

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Test Results

    13 files  ±0      13 suites  ±0   2h 47m 11s ⏱️ - 1m 48s
 6 909 tests +1   6 502 ✅  - 100  306 💤 ±0  101 ❌ +101 
18 356 runs  ±0  17 748 ✅  - 107  501 💤 ±0  107 ❌ +107 

For more details on these failures, see this check.

Results for commit a009abc. ± Comparison against base commit b8d73a4.

This pull request removes 358 and adds 359 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f91ed83d840>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc5e4051cc8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007ff7ed2612d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f91ed986558>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc5e4099758>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007ff7ef0539a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 61c370c6-26aa-4337-9dbc-803cafb736ab
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: ae4a9c28-1d1c-4cc9-9b92-ab8f330947e6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: cbf47cb6-5848-4a21-9a20-9a3abecdd37e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 05cbd50d-9f4a-44e0-93f5-4ddfedeb5927
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f6aefc2c458>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f72160f0b60>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fed985e7d00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f6aefc8a8c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f7215f53488>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fed985f3c18>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 208d6248-6a78-49d0-8ca3-325e781e6dc6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 2c86218f-4010-4bb9-920e-d57162448c2d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 3192226c-6b60-461c-bee2-5434cd96f5f4
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 9553600c-43e2-4bf0-aba5-92108142926a
…

♻️ This comment has been updated with latest results.

@randalldfloyd randalldfloyd marked this pull request as draft October 7, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants