Skip to content

Conversation

@mark-dce
Copy link
Contributor

@mark-dce mark-dce commented Nov 3, 2025

DO NOT MERGE!

Summary

Preliminary WIP to explore potential speed improvements from not running background jobs within background jobs.

Adds a feature flipper deterministic_jobs:
off: run jobs without modification (no change)
on: avoid queuing jobs when caller is already running in a backgorund worker

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Test Results

    13 files  ±0      13 suites  ±0   2h 58m 31s ⏱️ + 7m 5s
 6 888 tests ±0   6 577 ✅ +4  311 💤 ±0  0 ❌  - 4 
18 298 runs  ±0  17 785 ✅ +4  513 💤 ±0  0 ❌  - 4 

Results for commit eb05647. ± Comparison against base commit b2b6e92.

This pull request removes 367 and adds 367 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f2d6de67a98>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f7f3e4c3988>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc60529ac98>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f2d753d8200>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f7f3caf6e10>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc604441cc8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 9e016a49-5708-4f54-be39-88b36399259a
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 5e0bcf93-bf79-4beb-b737-48be85750986
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: f3fd9b4e-7d0c-45e4-8b3d-4bc94f737ce3
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 6e93b8d0-8c69-47ad-a215-eb4e27ad09f6
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f155a1749d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f58ae664c58>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f9d27292e50>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f155a1b49c0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f58ae1f5140>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f9d0d898490>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 03674008-7596-4f45-af63-8ae175270d8f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 78a43c86-5075-4495-a86d-fb5f3141a44b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 895a77ab-9823-41cf-8ea6-14fa83399abd
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: cf090456-3293-48a7-b14c-3f32c945ad4b
…

♻️ This comment has been updated with latest results.

@mark-dce mark-dce closed this Nov 3, 2025
Adds a feature flipper to allow us to pilot the feature while
retaining backwards compatibility.
@mark-dce mark-dce reopened this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants