Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added way to check if OBD is ready for another request #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TwoTenPvP
Copy link

Great library and super useful.

I have a modified version I use to ensure the lib never blocks with delays. But I think this fix is good to have upstream to allow a simple check before entering a read. It does not do away with delays when reading large packets but is a step in the right direction. (I use a modified pidRead that returns a constant until it has all the responses to prevent delay, but that's for a different time)

@TwoTenPvP
Copy link
Author

This also allows for some refactoring to lessen code reuse by calling this method instead of duplicating the check everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant