Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reference extraction logic from the German bank abstract class to the general abstract class #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beilsma
Copy link

@beilsma beilsma commented Jan 17, 2025

The logic for getting the references from the statement line (:61:) was defined in the GermanBank class, which German bank parsers extend.

Since Dutch banks use the identical statement line structure, this same logic can be used to extract these references from their statements as well.

This means the logic can be moved from the GermanBank class to the AbstractParser class, which is the base for all bank parsers, both German and Dutch banks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant