-
Notifications
You must be signed in to change notification settings - Fork 5
Add iframe support to canvas panel for MCP tool responses #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
17c6231
Initial plan
Copilot 3b19b6b
Add iframe support to canvas panel for MCP tools
Copilot 7d2269b
Add test for iframe canvas file creation from display config
Copilot c0f697a
Add HTML artifact demo with embedded iframe
Copilot 74bbf6b
Add iframe support documentation to developer guide
Copilot 2329e05
Address code review feedback
Copilot 76bf447
Extract constants and helper function for better maintainability
Copilot e2fa1f7
Merge remote-tracking branch 'origin/main' into copilot/allow-iframe-…
garland3 4e0d132
docs(ui-demo): enhance create_button_demo docstring with detailed sec…
garland3 f34f588
feat(security): update CSP configuration to allow external iframe loa…
garland3 8978ea9
feat(mcp): add example configurations for various MCP servers and upd…
garland3 72a5972
feat(mcp): enhance tool artifact processing to support iframe display…
garland3 2385c59
feat(tests): update MCP prompt tests to use example config and enhanc…
garland3 a745e67
feat(mcp): enhance MCPToolManager to support custom config paths and …
garland3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -85,7 +85,7 @@ FEATURE_SPLASH_SCREEN_ENABLED=false # Startup splash screen for displaying poli | |||||
| # Useful for testing or managing multiple configurations. | ||||||
| ############################################# | ||||||
| # SPLASH_CONFIG_FILE=splash-config.json # Splash screen configuration file name | ||||||
| # MCP_CONFIG_FILE=mcp.json # MCP servers configuration file name | ||||||
| # MCP_CONFIG_FILE=mcp.json # MCP servers configuration file name | ||||||
| # LLM_CONFIG_FILE=llmconfig.yml # LLM models configuration file name | ||||||
| # HELP_CONFIG_FILE=help-config.json # Help page configuration file name | ||||||
|
|
||||||
|
|
@@ -133,4 +133,9 @@ USE_MOCK_S3=true | |||||
| # S3_USE_SSL=false | ||||||
|
|
||||||
|
|
||||||
| SECURITY_CSP_VALUE="default-src 'self'; img-src 'self' data: blob:; script-src 'self'; style-src 'self' 'unsafe-inline'; connect-src 'self'; frame-src 'self' blob: data:; frame-ancestors 'self'" | ||||||
| # Content Security Policy (CSP) configuration | ||||||
| # IMPORTANT: To allow external URLs in iframes (for MCP tools that use iframe display), | ||||||
| # add the URLs to the frame-src directive. Example: | ||||||
| # SECURITY_CSP_VALUE="... frame-src 'self' blob: data: https://example.com https://dashboard.example.com; ..." | ||||||
| # HERE the www.sandia.gov is added as an allowed iframe source. | ||||||
|
||||||
| # HERE the www.sandia.gov is added as an allowed iframe source. | |
| # In this example, https://www.sandia.gov is added as an allowed iframe source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Inconsistent spacing alignment in the comment. Line 88 has extra spaces before the comment delimiter, while other lines (87, 89, 90) have a single space. For consistency, align with the pattern used in lines 87, 89, and 90.