Add system prompt loading functionality #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable system prompt to be automatically loaded from prompts/system_prompt.md and injected at the start of all conversations. This ensures consistent AI behavior and user personalization via email template variable. Changes: - Added PromptProvider.get_system_prompt() method - Added system_prompt_filename config setting - Updated MessageBuilder to inject system prompt - Added comprehensive test coverage - Updated CLAUDE.md documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
🔒 Security Scan ResultsSecurity Scan SummaryScan ResultsPython SAST (Bandit)Recommendations
|
Copilot finished reviewing on behalf of
garland3
November 25, 2025 00:05
There was a problem hiding this comment.
Pull request overview
This PR adds system prompt loading functionality to enable automatic injection of a configurable system prompt at the start of all conversations. The implementation integrates seamlessly with the existing prompt infrastructure and follows established code patterns.
Key Changes:
- Added
get_system_prompt()method to PromptProvider following the same pattern as existing prompt methods - Added
system_prompt_filenameconfiguration setting to AppSettings - Updated MessageBuilder to optionally prepend system prompt as the first message
- Wired PromptProvider into MessageBuilder via ChatOrchestrator
- Added comprehensive test coverage with 5 tests covering various scenarios
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| backend/modules/prompts/prompt_provider.py | Added get_system_prompt() method to load and format system prompt template with user_email substitution |
| backend/modules/config/config_manager.py | Added system_prompt_filename configuration setting (default: "system_prompt.md") |
| backend/application/chat/preprocessors/message_builder.py | Updated to accept optional PromptProvider and prepend system prompt when enabled |
| backend/application/chat/orchestrator.py | Wired PromptProvider into MessageBuilder initialization |
| backend/tests/test_system_prompt_loading.py | Added comprehensive test suite covering prompt loading, MessageBuilder integration, and end-to-end flow |
| CLAUDE.md | Added Prompt System documentation section explaining system prompt functionality and configuration |
| async def test_system_prompt_sent_to_llm(): | ||
| """Test that system prompt is sent to LLM in chat flow""" | ||
| # Create a temporary directory for prompts | ||
| import tempfile |
There was a problem hiding this comment.
Duplicate import of tempfile - already imported at line 1.
Suggested change
| import tempfile |
| @@ -0,0 +1,182 @@ | |||
| import tempfile | |||
There was a problem hiding this comment.
Import of 'tempfile' is not used.
Suggested change
| import tempfile |
🔒 Security Scan ResultsSecurity Scan SummaryScan ResultsPython SAST (Bandit)Recommendations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable system prompt to be automatically loaded from
prompts/system_prompt.mdand injected at the start of all conversations. This ensures consistent AI behavior and user personalization.Changes
get_system_prompt()method to load and format system prompt with{user_email}template variablesystem_prompt_filenamesetting (default:system_prompt.md)Test Results
✅ All 5 new tests pass
✅ All 271 backend tests pass
✅ All 108 frontend tests pass
✅ No regressions
Behavior
The system prompt from
prompts/system_prompt.mdis now:PromptProviderwith user email substitution🤖 Generated with Claude Code