Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 25, 2025

Bumps actions/setup-node from 4 to 6.

Release notes

Sourced from actions/setup-node's releases.

v6.0.0

What's Changed

Breaking Changes

Dependency Upgrades

Full Changelog: actions/setup-node@v5...v6.0.0

v5.0.0

What's Changed

Breaking Changes

This update, introduces automatic caching when a valid packageManager field is present in your package.json. This aims to improve workflow performance and make dependency management more seamless. To disable this automatic caching, set package-manager-cache: false

steps:
- uses: actions/checkout@v5
- uses: actions/setup-node@v5
  with:
    package-manager-cache: false

Make sure your runner is on version v2.327.1 or later to ensure compatibility with this release. See Release Notes

Dependency Upgrades

New Contributors

Full Changelog: actions/setup-node@v4...v5.0.0

v4.4.0

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4 to 6.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v4...v6)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 25, 2025

Assignees

The following users could not be added as assignees: security-team. Either the username does not exist or it does not have the correct permissions to be added as an assignee.

Labels

The following labels could not be found: dependencies, github-actions, security. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@garland3 garland3 merged commit d8134f6 into main Oct 25, 2025
5 of 8 checks passed
@dependabot dependabot bot deleted the dependabot/github_actions/actions/setup-node-6 branch October 25, 2025 04:30
garland3 added a commit that referenced this pull request Nov 7, 2025
Fixed bug where REQUIRE_TOOL_APPROVAL_BY_DEFAULT was treated as
admin-mandated instead of user-level, preventing the inline auto-approve
toggle from appearing in the UI.

Changes:
- Updated requires_approval() to return admin_required=False for default
  approval requirement, allowing users to toggle via inline UI
- Only FORCE_TOOL_APPROVAL_GLOBALLY and per-tool require_approval=true
  now set admin_required=True (user cannot override)
- Updated test expectations to match corrected behavior
- Enhanced docstring to clarify admin vs user-level approval logic

This ensures the inline toggle appears for all tool approvals except
those explicitly marked as admin-required.

Fixes requirement #4 from fn-approvals.md: "The user can easily toggle
auto approval via the UI settings panel OR when a tool approval is
requested an an inline ui element that is adjacent to the approval requests."

Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
garland3 added a commit that referenced this pull request Nov 8, 2025
…ls (#59)

* feat: Add comprehensive tool approval system with configurable controls

Implements a complete tool approval system that allows users to control
when and how LLM tool calls are executed, with support for argument editing,
per-tool configuration, and auto-approval settings.

Key Features:
- Tool approval manager with configurable approval policies
- Inline toggle for auto-approve in tool approval messages
- User-level and tool-level auto-approval settings
- Argument editing with tracked changes and LLM context
- Global force approval override for all tools
- WebSocket-based approval flow with request/response handling
- Comprehensive test coverage for approval manager and config
- CodeQL data extensions for sanitizers

Backend Changes:
- Add ToolApprovalManager for centralized approval logic
- Update agent loops (ReAct, Think-Act, Act) to support approval flow
- Add approval endpoints and WebSocket message handlers
- Integrate approval checks into tools mode runner
- Add configuration management for tool approval settings

Frontend Changes:
- Add tool approval UI in chat area
- Implement approval dialog with argument editing
- Add user-level auto-approval toggle in settings
- Track argument changes and provide context to LLM

Documentation:
- Complete implementation guide
- E2E test scenarios
- System architecture documentation

Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* fix: Correct tool approval logic to allow user-level toggles

Fixed bug where REQUIRE_TOOL_APPROVAL_BY_DEFAULT was treated as
admin-mandated instead of user-level, preventing the inline auto-approve
toggle from appearing in the UI.

Changes:
- Updated requires_approval() to return admin_required=False for default
  approval requirement, allowing users to toggle via inline UI
- Only FORCE_TOOL_APPROVAL_GLOBALLY and per-tool require_approval=true
  now set admin_required=True (user cannot override)
- Updated test expectations to match corrected behavior
- Enhanced docstring to clarify admin vs user-level approval logic

This ensures the inline toggle appears for all tool approvals except
those explicitly marked as admin-required.

Fixes requirement #4 from fn-approvals.md: "The user can easily toggle
auto approval via the UI settings panel OR when a tool approval is
requested an an inline ui element that is adjacent to the approval requests."

Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* fix(logging): sanitize sensitive data in log outputs for security

- Remove unused UUID import in approval_manager.py
- Sanitize tool_call_id keys and approval results in logs to prevent data leakage
- Clean up test code by removing unnecessary await approval_task statements
- Ensure all logged data is sanitized using sanitize_for_logging utility

* Potential fix for code scanning alert no. 435: Log Injection

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* refactor: improve logging and clean up test variables

- Switch websocket logging from f-string to parameterized format for better performance and security
- Remove unused approval_task variables in test_approval_manager.py to eliminate linter warnings and improve code clarity

* feat: sanitize logging inputs to prevent sensitive data leakage

- Applied sanitize_for_logging to user inputs, file paths, and config data in log messages across chat service, MCP tools, RAG client, and admin routes
- This prevents potential exposure of sensitive information in application logs, enhancing security and compliance

* feat(logging): Enhance sanitization to remove Unicode line separators

- Updated `sanitize_for_logging` in `backend/core/utils.py` to remove Unicode LINE SEPARATOR (U+2028) and PARAGRAPH SEPARATOR (U+2029) in addition to ASCII control characters, preventing log injection attacks and corruption from these characters.
- Modified logging format in `backend/main.py` to add brackets around message_type and keys for improved readability.
- Added comprehensive tests in `backend/tests/test_core_utils.py` to verify removal of Unicode separators, including edge cases with mixed characters.

---------

Co-authored-by: Claude <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants