-
Notifications
You must be signed in to change notification settings - Fork 5
security(actions): bump actions/setup-node from 4 to 6 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4 to 6. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v6) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Contributor
Author
AssigneesThe following users could not be added as assignees: LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
garland3
added a commit
that referenced
this pull request
Nov 7, 2025
Fixed bug where REQUIRE_TOOL_APPROVAL_BY_DEFAULT was treated as admin-mandated instead of user-level, preventing the inline auto-approve toggle from appearing in the UI. Changes: - Updated requires_approval() to return admin_required=False for default approval requirement, allowing users to toggle via inline UI - Only FORCE_TOOL_APPROVAL_GLOBALLY and per-tool require_approval=true now set admin_required=True (user cannot override) - Updated test expectations to match corrected behavior - Enhanced docstring to clarify admin vs user-level approval logic This ensures the inline toggle appears for all tool approvals except those explicitly marked as admin-required. Fixes requirement #4 from fn-approvals.md: "The user can easily toggle auto approval via the UI settings panel OR when a tool approval is requested an an inline ui element that is adjacent to the approval requests." Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
garland3
added a commit
that referenced
this pull request
Nov 8, 2025
…ls (#59) * feat: Add comprehensive tool approval system with configurable controls Implements a complete tool approval system that allows users to control when and how LLM tool calls are executed, with support for argument editing, per-tool configuration, and auto-approval settings. Key Features: - Tool approval manager with configurable approval policies - Inline toggle for auto-approve in tool approval messages - User-level and tool-level auto-approval settings - Argument editing with tracked changes and LLM context - Global force approval override for all tools - WebSocket-based approval flow with request/response handling - Comprehensive test coverage for approval manager and config - CodeQL data extensions for sanitizers Backend Changes: - Add ToolApprovalManager for centralized approval logic - Update agent loops (ReAct, Think-Act, Act) to support approval flow - Add approval endpoints and WebSocket message handlers - Integrate approval checks into tools mode runner - Add configuration management for tool approval settings Frontend Changes: - Add tool approval UI in chat area - Implement approval dialog with argument editing - Add user-level auto-approval toggle in settings - Track argument changes and provide context to LLM Documentation: - Complete implementation guide - E2E test scenarios - System architecture documentation Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * fix: Correct tool approval logic to allow user-level toggles Fixed bug where REQUIRE_TOOL_APPROVAL_BY_DEFAULT was treated as admin-mandated instead of user-level, preventing the inline auto-approve toggle from appearing in the UI. Changes: - Updated requires_approval() to return admin_required=False for default approval requirement, allowing users to toggle via inline UI - Only FORCE_TOOL_APPROVAL_GLOBALLY and per-tool require_approval=true now set admin_required=True (user cannot override) - Updated test expectations to match corrected behavior - Enhanced docstring to clarify admin vs user-level approval logic This ensures the inline toggle appears for all tool approvals except those explicitly marked as admin-required. Fixes requirement #4 from fn-approvals.md: "The user can easily toggle auto approval via the UI settings panel OR when a tool approval is requested an an inline ui element that is adjacent to the approval requests." Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * fix(logging): sanitize sensitive data in log outputs for security - Remove unused UUID import in approval_manager.py - Sanitize tool_call_id keys and approval results in logs to prevent data leakage - Clean up test code by removing unnecessary await approval_task statements - Ensure all logged data is sanitized using sanitize_for_logging utility * Potential fix for code scanning alert no. 435: Log Injection Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * refactor: improve logging and clean up test variables - Switch websocket logging from f-string to parameterized format for better performance and security - Remove unused approval_task variables in test_approval_manager.py to eliminate linter warnings and improve code clarity * feat: sanitize logging inputs to prevent sensitive data leakage - Applied sanitize_for_logging to user inputs, file paths, and config data in log messages across chat service, MCP tools, RAG client, and admin routes - This prevents potential exposure of sensitive information in application logs, enhancing security and compliance * feat(logging): Enhance sanitization to remove Unicode line separators - Updated `sanitize_for_logging` in `backend/core/utils.py` to remove Unicode LINE SEPARATOR (U+2028) and PARAGRAPH SEPARATOR (U+2029) in addition to ASCII control characters, preventing log injection attacks and corruption from these characters. - Modified logging format in `backend/main.py` to add brackets around message_type and keys for improved readability. - Added comprehensive tests in `backend/tests/test_core_utils.py` to verify removal of Unicode separators, including edge cases with mixed characters. --------- Co-authored-by: Claude <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps actions/setup-node from 4 to 6.
Release notes
Sourced from actions/setup-node's releases.
... (truncated)
Commits
2028fbcLimit automatic caching to npm, update workflows and documentation (#1374)1342781Bump actions/publish-action from 0.3.0 to 0.4.0 (#1362)89d709dBump prettier from 2.8.8 to 3.6.2 (#1334)cd2651cBump ts-jest from 29.1.2 to 29.4.1 (#1336)a0853c2Bump actions/checkout from 4 to 5 (#1345)b7234ccUpgrade action to use node24 (#1325)d7a1131Enhance caching in setup-node with automatic package manager detection (#1348)5e2628cBumps form-data (#1332)65becefBump undici from 5.28.5 to 5.29.0 (#1295)7e24a65Bump uuid from 9.0.1 to 11.1.0 (#1273)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)