Centralize configuration through ConfigManager

[Copilot]

Scattered os.getenv() calls throughout the codebase made configuration hard to understand and maintain. This consolidates all environment variable loading through the existing ConfigManager.

Changes

Extended AppSettings with previously scattered configuration:

• Config paths: app_config_overrides, app_config_defaults, app_log_dir
• Runtime settings: environment, runtime_feedback_dir
• Prompt injection thresholds: pi_threshold_low/medium/high

Replaced direct env access in 8 files:

• core/capabilities.py, core/otel_config.py, core/prompt_risk.py
• routes/feedback_routes.py, routes/admin_routes.py, routes/config_routes.py
• modules/mcp_tools/client.py

Usage pattern:

# Before: scattered throughout codebase
threshold = int(os.getenv("PI_THRESHOLD_LOW", "30"))
log_dir = Path(os.getenv("APP_LOG_DIR") or "logs")

# After: centralized through ConfigManager
from modules.config import config_manager
threshold = config_manager.app_settings.pi_threshold_low
log_dir = Path(config_manager.app_settings.app_log_dir or "logs")

All settings now flow through Pydantic's type-validated AppSettings in modules/config/manager.py. Bootstrap fallbacks preserved in otel_config.py for early initialization.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• astral.sh
  • Triggering command: curl -LsSf REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>centralize the config setup</issue_title>
<issue_description>everything is loaded in one config manager
no loading of random env vars.
easy to understand and configure. </issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes centralize the config setup #15

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

To fix the problem, the except Exception: block should include a logging statement to record that the primary configuration path failed, with the exception details. This ensures that, if there is a problem with the configuration, its nature is not lost, and debugging is easier. The log level should likely be warning, as the program will fallback to a default and continue working, but the failure is noteworthy.

The code change should be in backend/core/otel_config.py, within the _get_logs_dir method. Add a comment explaining the fallback and log the exception (using logging.warning). Since the class handles logging configuration, but may not have been set up yet at this point, basic logging to the root logger is acceptable.

No new imports are needed, as logging is already imported.

---

[garland3]

After some additional changes this looks good.

To resolve the unused import error, simply remove the line import pytest from the file backend/tests/test_config_manager.py. This will eliminate unnecessary dependency and improve code readability. No other changes are needed, as no features or symbols from pytest are referenced directly in this file.

---