Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves two issues building on OSX:
<machine/endian.h>
instead of<endian.h>
, and while a conditional include could be done with preprocessor directives (or passingCFLAGS="$CFLAGS -I~/usr/include/machine
conditionally in CMake), using<sys/types.h>
(which is cross platform) seems easier.std::min
andstd::max
calls. Or maybe you would prefer to cast these to the same type... if so i can update to that behavior, let me know. Either way whats in here fails on OSX.