Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP v1.7.5 #319

Merged
merged 22 commits into from
Feb 15, 2025
Merged

WIP v1.7.5 #319

merged 22 commits into from
Feb 15, 2025

Conversation

sandrohanea
Copy link
Owner

No description provided.

@sandrohanea
Copy link
Owner Author

Temporary blocked after ggml-org/llama.cpp#10890 disabled the support for MSVC build for ARM targets.

Tried to use LLVM (Clang) with both Ninja Generator:

(base) PS C:\Projects\sandrohanea\whisper.net> cmake -S . -B build/win-arm64     -DGGML_NATIVE=OFF     -DCMAKE_C_COMPILER="clang"     -DCMAKE_CXX_COMPILER="clang++"       -DCMAKE_SYSTEM_PROCESSOR=arm64 -DCMAKE_C_COMPILER_TARGET="arm64-pc-windows-msvc" -DCMAKE_CXX_COMPILER_TARGET="arm64-pc-windows-msvc" -DCMAKE_C_FLAGS_INIT="-gcodeview -march=armv8.7-a -fvectorize -ffp-model=fast -fno-finite-math-only -Wno-format -Wno-unused-variable -Wno-unused-function -Wno-gnu-zero-variadic-macro-arguments" -DCMAKE_CXX_FLAGS_INIT="-gcodeview -march=armv8.7-a -fvectorize -ffp-model=fast -fno-finite-math-only -Wno-format -Wno-unused-variable -Wno-unused-function -Wno-gnu-zero-variadic-macro-arguments" -G Ninja
-- The C compiler identification is Clang 18.1.8 with GNU-like command-line
-- The CXX compiler identification is Clang 18.1.8 with GNU-like command-line
-- Detecting C compiler ABI info
CMake Error in C:/Projects/sandrohanea/whisper.net/build/win-arm64/CMakeFiles/CMakeScratch/TryCompile-jphhze/CMakeLists.txt:
  MSVC_DEBUG_INFORMATION_FORMAT value 'ProgramDatabase' not known for this C
  compiler.


CMake Error at C:/Program Files/Microsoft Visual Studio/2022/Preview/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.30/Modules/CMakeDetermineCompilerABI.cmake:74 (try_compile):
  Failed to generate test project build system.
Call Stack (most recent call first):
  C:/Program Files/Microsoft Visual Studio/2022/Preview/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.30/Modules/CMakeTestCCompiler.cmake:26 (CMAKE_DETERMINE_COMPILER_ABI)
  CMakeLists.txt:12 (project)

Inspired from https://github.com/ggerganov/llama.cpp/blob/master/cmake/arm64-windows-llvm.cmake and https://github.com/ggerganov/llama.cpp/blob/c05e8c9934f94fde49bc1bc9dc51eed282605150/.github/workflows/build.yml#L668C13-L668C144

But also tried with Visual Studio generator (without success).

It seems that Whisper.cpp doesn't have an ARM build of Windows in their CI: https://github.com/ggerganov/whisper.cpp/blob/2ab2eb5110018a1efd2744b7d4465209cf243e4c/.github/workflows/build.yml#L426C8-L434C26

@sandrohanea
Copy link
Owner Author

Build finished but cannot merge yet.
It seems that clang build of whisper.cpp runtime for x86/x64 is deadlocking the tests, reverting to MSVC fixes the issue.

I don't have yet an arm64 host so I cannot test arm64 build to see if it will deadlock as well or not and the new ggml version requires clang.

@sandrohanea sandrohanea merged commit d406461 into main Feb 15, 2025
48 checks passed
@sandrohanea sandrohanea deleted the v175 branch February 15, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant