Revise middleware handling#2521
Draft
ahopkins wants to merge 12 commits into
Draft
Conversation
Codecov ReportBase: 87.844% // Head: 70.943% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2521 +/- ##
==============================================
- Coverage 87.844% 70.943% -16.901%
==============================================
Files 78 70 -8
Lines 6466 5627 -839
Branches 1247 972 -275
==============================================
- Hits 5680 3992 -1688
- Misses 560 1465 +905
+ Partials 226 170 -56
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ahopkins
commented
Sep 15, 2022
Member
Author
|
A lot more use cases to consider with some potential breaking changes. Will be safer to kick this one out until after LTS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to: