Skip to content

Fix #3131: SSL configuration respected for non-primary apps#3154

Open
MuraveyApp wants to merge 1 commit into
sanic-org:mainfrom
MuraveyApp:fix/3131-ssl-non-primary-apps
Open

Fix #3131: SSL configuration respected for non-primary apps#3154
MuraveyApp wants to merge 1 commit into
sanic-org:mainfrom
MuraveyApp:fix/3131-ssl-non-primary-apps

Conversation

@MuraveyApp
Copy link
Copy Markdown

Summary

  • Fixes SSL configuration being ignored for non-primary apps when serving multiple apps
  • Non-primary apps now correctly use their SSL config instead of falling back to HTTP

Test plan

  • Verify multi-app serving with SSL works for all apps
  • Existing test suite passes

Generated by OwlMind — 96.67% on SWE-bench Lite

@MuraveyApp MuraveyApp requested a review from a team as a code owner April 8, 2026 19:58
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.704%. Comparing base (785d77f) to head (92e54ec).

Files with missing lines Patch % Lines
sanic/worker/serve.py 0.000% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main     #3154       +/-   ##
=============================================
- Coverage   87.793%   87.704%   -0.090%     
=============================================
  Files          105       105               
  Lines         8143      8149        +6     
  Branches      1290      1292        +2     
=============================================
- Hits          7149      7147        -2     
- Misses         687       694        +7     
- Partials       307       308        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant