fix: Scheduled publishing badge issue #8510

bobinska-dev · 2025-02-05T12:51:25Z

Added check for missing upcomingSchedule.action

Description

fix for: ScheduledBadge is rendered with an invalid state causing the component to crash the Studio

Added check for missing upcoming schedule action

What to review

Testing

Notes for release

Bug: When upcomingSchedule.action is undefined, the Studio breaks due to a missing check.

This line causes it:

  if (!upcomingSchedule || !upcomingSchedule.executeAt) {
    return null
  }

Fix:

  if (!upcomingSchedule || !upcomingSchedule.executeAt || !upcomingSchedule.action) {
    return null
  }

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: Bjørge Næss <[email protected]>

Added check for missing `upcomingSchedule.action`

vercel · 2025-02-05T12:51:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 5, 2025 1:10pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 5, 2025 1:10pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 5, 2025 1:10pm

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Feb 5, 2025 1:10pm
test-next-studio	⬜️ Ignored (Inspect)			Feb 5, 2025 1:10pm

github-actions · 2025-02-05T12:59:41Z

No changes to documentation

github-actions · 2025-02-05T13:00:03Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.39%	53648 / 126540
🔵	Statements	42.39%	53648 / 126540
🔵	Functions	47.86%	2763 / 5772
🔵	Branches	78.79%	10284 / 13051

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/sanity/src/core/scheduledPublishing/plugin/documentBadges/scheduled/ScheduledBadge.tsx	28.57%	100%	0%	28.57%	15-32

Generated in workflow #29864 for commit 2fc775b by the Vitest Coverage Report Action

…ing-badge

RitaDias

How nice to see your face around these parts @bobinska-dev 😄
This looks good and I tested it on the deployment and seems to work well!

Nice work!

github-actions · 2025-02-05T13:03:58Z

Component Testing Report Updated Feb 5, 2025 1:09 PM (UTC)

❌ Failed Tests (1) -- expand for details

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 7s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	12s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	❌ Failed (Inspect)	1m 19s	5	0	1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	51s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	26s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	14s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	27s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 8s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 30s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	2m 2s	21	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	13s	3	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	26s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 43s	21	0	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3	0

github-actions · 2025-02-05T13:07:33Z

⚡️ Editor Performance Report

Updated Wed, 05 Feb 2025 13:11:23 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	20.0 efps (50ms)	23.5 efps (43ms)	-8ms (-15.0%)	✅
article (body)	69.9 efps (14ms)	67.3 efps (15ms)	+1ms (-/-%)	✅
article (string inside object)	24.4 efps (41ms)	23.8 efps (42ms)	+1ms (+2.4%)	✅
article (string inside array)	20.8 efps (48ms)	21.3 efps (47ms)	-1ms (-2.1%)	✅
recipe (name)	48.8 efps (21ms)	47.6 efps (21ms)	+1ms (+2.4%)	✅
recipe (description)	52.6 efps (19ms)	52.6 efps (19ms)	+0ms (-/-%)	✅
recipe (instructions)	99.9+ efps (5ms)	99.9+ efps (5ms)	+0ms (-/-%)	✅
synthetic (title)	18.2 efps (55ms)	18.0 efps (56ms)	+1ms (+0.9%)	✅
synthetic (string inside object)	18.5 efps (54ms)	18.9 efps (53ms)	-1ms (-1.9%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	50ms	73ms	80ms	517ms	1322ms	12.3s
article (body)	14ms	19ms	34ms	300ms	511ms	5.9s
article (string inside object)	41ms	44ms	48ms	306ms	467ms	7.5s
article (string inside array)	48ms	51ms	56ms	181ms	749ms	8.4s
recipe (name)	21ms	23ms	24ms	40ms	0ms	7.2s
recipe (description)	19ms	20ms	22ms	30ms	0ms	4.6s
recipe (instructions)	5ms	6ms	8ms	21ms	0ms	3.1s
synthetic (title)	55ms	60ms	113ms	447ms	1446ms	18.6s
synthetic (string inside object)	54ms	64ms	112ms	780ms	1895ms	9.7s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	43ms	51ms	74ms	479ms	880ms	11.5s
article (body)	15ms	18ms	24ms	186ms	278ms	5.6s
article (string inside object)	42ms	45ms	50ms	144ms	295ms	7.4s
article (string inside array)	47ms	49ms	56ms	194ms	427ms	7.5s
recipe (name)	21ms	22ms	27ms	52ms	0ms	7.3s
recipe (description)	19ms	20ms	21ms	28ms	0ms	4.6s
recipe (instructions)	5ms	6ms	9ms	22ms	0ms	3.1s
synthetic (title)	56ms	60ms	106ms	332ms	1031ms	13.2s
synthetic (string inside object)	53ms	56ms	68ms	295ms	1188ms	8.8s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

bobinska-dev · 2025-02-05T14:01:59Z

@RitaDias I am daring to do more now 😎 although all the real work was done by @azaxarov 🙌

The only check that failed was related to component testing of PTE annotations, which is unrelated to this... Not sure how to proceed from here

RitaDias · 2025-02-05T14:04:28Z

@RitaDias I am daring to do more now 😎 although all the real work was done by @azaxarov 🙌

The only check that failed was related to component testing of PTE annotations, which is unrelated to this... Not sure how to proceed from here

Replied on the linear story, let's hold on merging just for a 🤏

pedrobonamin

Thank you!

The merge-base changed after approval.

renovate bot and others added 6 commits February 4, 2025 22:01

chore(deps): update pnpm to v9.15.5 (#8498)

d5252af

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore: upgrade vitest to v3 (#8371)

ea6ca8c

chore(e2e): retry e2e tests when running in CI (#8501)

14c4315

chore: restricting scheduled release UI (#8506)

af6e03a

test: enable test coverage (#7789)

bdb97c1

Co-authored-by: Bjørge Næss <[email protected]>

fix: Scheduled publishing badge

0909a87

Added check for missing `upcomingSchedule.action`

bobinska-dev requested a review from a team as a code owner February 5, 2025 12:51

bobinska-dev requested review from RitaDias and removed request for a team February 5, 2025 12:51

vercel bot deployed to Preview – page-building-studio February 5, 2025 12:57 View deployment

vercel bot deployed to Preview – performance-studio February 5, 2025 12:57 View deployment

vercel bot deployed to Preview – test-studio February 5, 2025 12:58 View deployment

bobinska-dev self-assigned this Feb 5, 2025

Merge remote-tracking branch 'origin/next' into fix-scheduled-publish…

2fc775b

…ing-badge

RitaDias previously approved these changes Feb 5, 2025

View reviewed changes

vercel bot deployed to Preview – performance-studio February 5, 2025 13:09 View deployment

vercel bot deployed to Preview – page-building-studio February 5, 2025 13:09 View deployment

vercel bot deployed to Preview – test-studio February 5, 2025 13:10 View deployment

pedrobonamin previously approved these changes Feb 5, 2025

View reviewed changes

pedrobonamin force-pushed the next branch from 75b6eab to 0d4e40d Compare February 5, 2025 16:24

pedrobonamin requested a review from a team as a code owner February 5, 2025 16:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Scheduled publishing badge issue #8510

fix: Scheduled publishing badge issue #8510

bobinska-dev commented Feb 5, 2025 •

edited by RitaDias

Loading

vercel bot commented Feb 5, 2025 •

edited

Loading

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025 •

edited

Loading

RitaDias left a comment

github-actions bot commented Feb 5, 2025 •

edited

Loading

github-actions bot commented Feb 5, 2025 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

bobinska-dev commented Feb 5, 2025

RitaDias commented Feb 5, 2025

pedrobonamin left a comment

fix: Scheduled publishing badge issue #8510

Are you sure you want to change the base?

fix: Scheduled publishing badge issue #8510

Conversation

bobinska-dev commented Feb 5, 2025 • edited by RitaDias Loading

Description

What to review

Testing

Notes for release

vercel bot commented Feb 5, 2025 • edited Loading

github-actions bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025 • edited Loading

Coverage Report

RitaDias left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 5, 2025 • edited Loading

github-actions bot commented Feb 5, 2025 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

bobinska-dev commented Feb 5, 2025

RitaDias commented Feb 5, 2025

pedrobonamin left a comment

Choose a reason for hiding this comment

bobinska-dev commented Feb 5, 2025 •

edited by RitaDias

Loading

vercel bot commented Feb 5, 2025 •

edited

Loading

github-actions bot commented Feb 5, 2025 •

edited

Loading

github-actions bot commented Feb 5, 2025 •

edited

Loading

github-actions bot commented Feb 5, 2025 •

edited

Loading